3 ms·

What is the sort of guidelines it violated?

• lifthrasiir 6y ago
  It wasn't obfuscated at all. The guideline doesn't explicitly dislike such entries, but as a side effect of not being obfuscated it implicitly violated several guidelines at once (e.g. it was quite "longer than [it] need[s] to be"). Indeed, today's nginx source code [1] would be probably slightly more obfuscated than this code modulo perhaps name changes (and that can be considered as a minimal effort to get the entry within the size limit). Its only obfuscation was reusing a buffer from getenv() pre-initialized (referred as to "getenv() == "putenv()" in the hint). [1] for example, https://github.com/nginx/nginx/blob/8365f73/src/http/ngx_http_parse.c#L108-L128 https://github.com/nginx/nginx/blob/8365f73/src/http/ngx_htt...