3 ms·
My point is that you can’t know the full impact of a code change without the full context of the change. Just a silly, trivial example: someone opens a PR to ch
by eyelidlessness 6y ago
My point is that you can’t know the full impact of a code change without the full context of the change. Just a silly, trivial example: someone opens a PR to change a brand color on a website’s theme. You see one line of code changed but the effect is probably far reaching. Now, using only a diff, you have to trust that either the tooling or the human or both have validated every usage under every scenario to identify regressions. Is some placement of that color now too low contrast? Is it too jarring in dark mode? Is it being used for non-brand purposes because someone got lazy, and changing far more than intended? How can you know unless you have the rest of the code base in your head? Do you trust your test coverage?