3 ms·

I'm realizing you are using "have readability" in a specialized way I may not be following. Can you say more what you mean by "whether you have readability" and

I'm realizing you are using "have readability" in a specialized way I may not be following. Can you say more what you mean by "whether you have readability" and "readability is a process...". Readability is a process (not an adjective)? That only some teams have? Can you say more?

Rebelgecko 6y ago
thedance provided a nice overview of the "readability" process here: https://news.ycombinator.com/item?id=22620455 https://news.ycombinator.com/item?id=22620455 Essentially what it means is that, when writing code in certain programming languages, one of your code reviewers has to have proved that they're fluent in that language and the style guide for it.
hemogloben 6y ago
Based on [1]; readability in google means you've been certified to review code according to Google's code style in a given language. Seems like if you've been certified you don't need an extra person who has been certified in 'readability' to review your code so it makes it easier. 1) https://www.pullrequest.com/blog/google-code-review-readability-certification/ https://www.pullrequest.com/blog/google-code-review-readabil...
joshuamorton 6y ago
Code changes generally require 3 things: 1. LGTM (that is, any second set of eyes) 2. Readability Approval 3. Owners approval (similar to github ownership) The CL author can provide readability and ownership, if I have python readability and own the file I'm changing, anyone else can LGTM. But if not, at least one of my reviewers needs to provide the language approvals. There's a process for gaining readability in a particular language, where you send your normal code changes to be additionally reviewed by experts who give deeper feedback on language idioms/use. This process is contentious because Google is fairly strict about style guides, and the readability reviewers goal is to ensure that you are writing idiomatic code, not to ensure your changes get submitted fast, so they'll often request changes and delay things (but this is known in advance, and for a high priority change, there are other avenues to get language approvals). After you are granted readability, you no longer need approval from someone else with readability for changes in that language. Personally, I found the process valuable for all of the languages I've gone through it in, but I can absolutely understand people's frustration, especially when dealing with deadlines or similar.
- Goog_l_Dude_l 6y ago
  It was certainly valuable, especially in C++ which includes a lot of internal standards and libraries, although at times I felt like a lot of these conventions can be enforced by a smarter linter, but I am writing better C++ code after this process despite having years of experience pre-Google. I didn't feel the same for Python though.

Rebelgecko 6y ago

thedance provided a nice overview of the "readability" process here: https://news.ycombinator.com/item?id=22620455 https://news.ycombinator.com/item?id=22620455 Essentially what it means is that, when writing code in certain programming languages, one of your code reviewers has to have proved that they're fluent in that language and the style guide for it.

hemogloben 6y ago

Based on [1]; readability in google means you've been certified to review code according to Google's code style in a given language. Seems like if you've been certified you don't need an extra person who has been certified in 'readability' to review your code so it makes it easier. 1) https://www.pullrequest.com/blog/google-code-review-readability-certification/ https://www.pullrequest.com/blog/google-code-review-readabil...

joshuamorton 6y ago

Code changes generally require 3 things: 1. LGTM (that is, any second set of eyes) 2. Readability Approval 3. Owners approval (similar to github ownership) The CL author can provide readability and ownership, if I have python readability and own the file I'm changing, anyone else can LGTM. But if not, at least one of my reviewers needs to provide the language approvals. There's a process for gaining readability in a particular language, where you send your normal code changes to be additionally reviewed by experts who give deeper feedback on language idioms/use. This process is contentious because Google is fairly strict about style guides, and the readability reviewers goal is to ensure that you are writing idiomatic code, not to ensure your changes get submitted fast, so they'll often request changes and delay things (but this is known in advance, and for a high priority change, there are other avenues to get language approvals). After you are granted readability, you no longer need approval from someone else with readability for changes in that language. Personally, I found the process valuable for all of the languages I've gone through it in, but I can absolutely understand people's frustration, especially when dealing with deadlines or similar.

Goog_l_Dude_l 6y ago
It was certainly valuable, especially in C++ which includes a lot of internal standards and libraries, although at times I felt like a lot of these conventions can be enforced by a smarter linter, but I am writing better C++ code after this process despite having years of experience pre-Google. I didn't feel the same for Python though.