2 ms·
That's definitely curious. If the median latency is under 4 hours, does that mean there are lots of people sitting around doing nothing, or working on nothing u
by throwawaysea 6y ago
That's definitely curious. If the median latency is under 4 hours, does that mean there are lots of people sitting around doing nothing, or working on nothing urgent, so that they can immediately turn around a code review?
- jdale27 6y ago> does that mean there are lots of people sitting around doing nothing, or working on nothing urgent, so that they can immediately turn around a code review? No, it means there is a cultural expectation / etiquette that you prioritize keeping your teammates unblocked by reviewing their code quickly, even if it means putting aside your own coding to do so.
- joshuamorton 6y agoIn addition to what the other user said, most changes are also small. Google's infra and culture encourages changes that are the size of a commit, not a pull request. This depends on the particular language and context, but simple, isolated, and usually small changes are preferred and encouraged. This allows relatively quick review for lots of things. If I see a change that modifies a single function and adds a test to validate the change in functionality, that's very quick to review.