4 ms·
> I’m about to accept a PR that will increase druid’s compile time about 3x and its executable size almost 2x I looked at the PR and it is a mere 700 LOC. I ag
by baby 6y ago
> I’m about to accept a PR that will increase druid’s compile time about 3x and its executable size almost 2x
I looked at the PR and it is a mere 700 LOC. I agree that compile time are an awful thing in Rust, but there are big glaring issues as well: LOC expansion and dependencies expansion.
- richardwhiuk 6y agoThis change: [dependencies] fluent-bundle = "0.7" fluent-locale = "0.7" fluent-syntax = "0.9" unic-langid = "0.4.1" and the corresponding change in Cargo.lock is the reason. I'm not sure about how you are expecting dependencies to be handled?
- baby 6y agoYeah, that's the issue. Dependencies growth is absurd in Rust. > I'm not sure about how you are expecting dependencies to be handled? I'll give you my point of view: a better standard library.
- richardwhiuk 6y agoThat just mean every binary needs to ship everything, even stuff they don't use.