2 ms·
I don't really have a problem untangling my changes into different commit. In fact, I often untangle them into separate pull requests. Though for very small cha
by mcv 6y ago
I don't really have a problem untangling my changes into different commit. In fact, I often untangle them into separate pull requests. Though for very small changes, that's overkill.
I consider small fixes unrelated to my main change acceptable if they're in the same file. If not in the same file, that means they're probably easy to put in a different commit or PR. Which one of those it is, depends on how big the change is, and whether it constitutes a meaningful change.
Having to think about this after I've done the work has been done, seems to be the right time to think about it for me. Though maybe not for the author. For people who prefer a different workflow, I guess it's nice to now have that option.