3 ms·

> if byte.length > 2 and (byte[1] == 'x' or byte[1] == 'x') Am I going crazy or is the `or` clause completely pointless?

• minitech 6y ago
  One of them is uppercase in the actual code.
  • 0xdba 6y ago
    https://github.com/rs/node-netmask/commit/ec1b5b56a822babf90e1e14d7fc8a56e06ba9013#diff-04f4f5b6e6cd99b4a664143f590d40d005f9b658d4ae0678ddc25c49bed19e2bR13 https://github.com/rs/node-netmask/commit/ec1b5b56a822babf90... I don't see it.
    • minitech 6y ago
      Ah, sorry, it was fixed in https://github.com/rs/node-netmask/commit/3f19a056c4eb808ea4a29f234274c67bc5a848f4#diff-04f4f5b6e6cd99b4a664143f590d40d005f9b658d4ae0678ddc25c49bed19e2b https://github.com/rs/node-netmask/commit/3f19a056c4eb808ea4.... And good catch, of course :)