3 ms·
For the record, I did not mean to imply that py-bcrypt was malicious. All I intended was that I think it's prudent to understand discrepancies like these becau
by lisper 15y ago
For the record, I did not mean to imply that py-bcrypt was malicious. All I intended was that I think it's prudent to understand discrepancies like these because they could some day be an indication of something malicious. I apologize for the misunderstanding.
- tptacek 15y agoFrom your post: OK, so maybe someone accidentally introduced an off-by-one error into the python wrapper. Except that the problem is not in the python wrapper. You can find bcrypt test vectors on the web, and they are all 60-byte strings. ... and: That is a very big discrepancy between the actual behavior of the code and the description given in the literature. It's vastly too big a discrepancy to be explainable by a simple inadvertent bug. .... and: Now, some people might say I'm being excessively paranoid, but I don't think so. The higher the stakes in the internet security game get, the more incentive there is for attackers to try all kinds of sneaky and nefarious tricks to introduce weaknesses into people's defenses, and one of the easiest ways to do that is to publish some plausible-looking open-source security code that actually has a hidden weakness built in to it [!!!] and hope that nobody notices. Give me a break. And lest the tl;dr's think I'm cherry picking: this stuff is the bulk of the post. Ed: fixed ems.
- TeMPOraL 15y agoTechnical question: you want to emphasize the em-ed text or the plain text? I'm not sure, because it seems to me that the text you left unformatted is more relevant in this context that em-ed one. Edit: thx :).
- lisper 15y agoI can see how someone could read that as implying that I thought the author of py-bcrypt was being malicious. All I can say is that wasn't my intent. My intent was that I didn't think it was being overly paranoid to try to understand what was going on, whatever it was.
- true_religion 15y agoIt's funny how we're looking at the same text and arriving at opposite meanings. Let me highlight some things from your quotes. 1. "Except that the problem is not in the python wrapper" - This directly says that the Python author is not being malicious---how can he be since he isn't at fault for the error? The essayist continues to explain why the Python author is not at fault. 2. "You can find bcrypt test vectors on the web, and they are all 60-byte strings." - This bug is wide-spread. 3. "That is a very big discrepancy between the actual behavior of the code and the description given in the literature. It's vastly too big a discrepancy to be explainable by a simple inadvertent bug." - The bug is too large to be an inadverdent bug introduced independently by every author. 4. "Now, some people might say I'm being excessively paranoid, but I don't think so. <snip>" Here the author is only defending his rationale for looking for bugs in an open source project. He isn't implying that he has now found one that shows the authors are malicious.