3 ms·
Not defending the article at all, but "whose head" should be at least a code reviewer's head, ideally two.
by lupire 6y ago
Not defending the article at all, but "whose head" should be at least a code reviewer's head, ideally two.
- alfonsodev 6y agoI believe that there are people that can handle more abstractions in their working memory, maybe up to 6 or 7 layers of abstraction, and there are people that can't go further than 3, before feeling lost. The "bigger heads" types will use SOLID or any other argument to justify a higher number of abstractions. While the other type will do the same to justify a lesser. At the end of the day, there is no right solution, but what is so called "cultures" that group people with similar taste and cognitive fingerprint, and provide best practices.
- Pxtl 6y agoYup. As a PR reviewer, my gold standard is "I understand 100% of what's going on in this change, and I'm confident it does what it says it does". All the rules and standards and stuff we put in place is basically in support of that goal. If I can't understand it, neither can the next guy.