2 ms·
I'm also a bit curious as to what deficiencies you're trying to address in the existing py-bcrypt library? Similarly, how did you decide to make this a Flask ex
by llambda 15y ago
I'm also a bit curious as to what deficiencies you're trying to address in the existing py-bcrypt library? Similarly, how did you decide to make this a Flask extension, versus a standalone Python module? It doesn't look like you're actually doing anything Flask-specific. Do you have broader plans for the project?
I don't think there's any deficiencies regarding py-bcrypt that I'm attempting to address; the idea here is to provide some convenience functions for Flask apps so that they can import an extension and have a drop-in replacement for werkzeug.security's password hashing utilities (which do not support bcrypt at this time). Hopefully this can happen without having to edit any existing code, beyond adding the import. This extension is similar to the Django bcrypt module although I understand they provide some other functionality as well.
I like the idea about adding rounds to the app.config. I definitely will plan on adding this.
And I've made some edits regarding your suggestions above, currently fixing the tests and then I'll push some updates.
Thanks for the feedback! :)
Edit: I tried to merge your changes but failed. I'm sure I was doing something wrong but I've only been able to do it when someone has made a pull request. I tried to add your fork as a remote and then pull from the remote and merge but somehow the conflicts were saved without being merged and then pushed. Anyway I appreciate you taking the time to make the changes you pointed out and I would gladly have used them directly if I were a little more finessed with git.