4 ms·
> Of course it's a lot easier and less risky to simply post a mocking tweet and walk away. This tweet seems to be from Jason Donenfeld, who worked for years to
by JackC 6y ago
> Of course it's a lot easier and less risky to simply post a mocking tweet and walk away.
This tweet seems to be from Jason Donenfeld, who worked for years to refactor linux kernel crypto APIs as part of upstreaming wireguard, apparently with some success. (Random link for some context, though I haven't followed the whole arc of that story: https://www.phoronix.com/scan.php?page=news_item&px=Crypto-API-Doing-Some-Zinc https://www.phoronix.com/scan.php?page=news_item&px=Crypto-A... )
If you're aware of that context and think that Donenfeld is too critical of the kernel and hasn't done enough to fix it, then OK, but from an outside perspective it sure looks like he's put a ton of time into fixing things and earned some right to point out remaining issues.
- st_goliath 6y agoThanks for the info! I only saw the twitter thread doing the usual point and laugh game and didn't bother looking further into at, given how often you stumble across those. Not being a Twitter user but tangentially following Wireguard development, the name Jason Donenfeld does ring a bell, in contrast to some Twitter account named "Edge Security". Interesting to know that the tweet from 2017 pointing out code duplication in the kernel is from the same person who, 1 year later, kicked off a brief flame war by wanting their own crypto library merged into the kernel alongside the existing one[1], before finally giving in and porting Wireguard to the existing API[2]. EDIT: Also thanks for pointing at the patch set for the crypto API. I have yet to look into that, as the last time I touched the kernel crypto API was a few years prior and I agree with some of Jasons criticism, although I can see the point of the kernel API being designed for asynchronous workloads, trying to explicitly support hardware accelerators, which I was also playing around with back then. [1] https://lore.kernel.org/lkml/CAKv+Gu9hOW0pOjDjrvg1q-v85aiwSZRnjivnvRTCwxMdph4j7g@mail.gmail.com/ https://lore.kernel.org/lkml/CAKv+Gu9hOW0pOjDjrvg1q-v85aiwSZ... [2] https://lists.zx2c4.com/pipermail/wireguard/2019-September/004560.html https://lists.zx2c4.com/pipermail/wireguard/2019-September/0...