3 ms·
> when not i always get a comment during a code review. Why during CR? Is the error not obvious to you? You should be able to check the results of your changes
by jasonpeacock 6y ago
> when not i always get a comment during a code review.
Why during CR? Is the error not obvious to you? You should be able to check the results of your changes before pushing, right?
- zimmski 6y agoI/we do but sometimes you just overlook something especially if there are a lot of changes. But having someone else review what you do almost completely removes that problem. I usually do not look through all commits again when a basic review already happend and i "just" integrate the review comments. That is where for me personally these problems happen that git-autofixup is sometimes wrong but in over a few thousand commits in the last months this happend only thrice. Which for me just speaks for the tool IMHO. Ow the original author big time :-)
- torbiak 6y agoCool, I'm glad it's working out for you. Due to my workflow at my current job I haven't actually had much occasion to use it since writing it, so I'm not that confident about how good the hueristics are. Do you generally use the default --strict setting?