3 ms·
Currently active review: https://forums.swift.org/t/se-0306-actors/45734 https://forums.swift.org/t/se-0306-actors/45734 Review by Chris Lattner: https://forum
by DelightOne 6y ago
Currently active review: https://forums.swift.org/t/se-0306-actors/45734 https://forums.swift.org/t/se-0306-actors/45734
Review by Chris Lattner: https://forums.swift.org/t/se-0306-actors/45734/4 https://forums.swift.org/t/se-0306-actors/45734/4
- gigatexal 6y agoChris's review is really impressive. Anyone doing code review should take note.
- macintux 6y agoI agree: well-written, well-presented, well-considered. (Of course I'm heavily biased against inheritance, but I think it's a very good review regardless.)
- gigatexal 6y agoTechnical aspects aside I really enjoyed the empathy he showed, spending considerable time showering love to the author on what he liked about the proposal and how well it was written and how overall he’s excited and then skillfully transitioned into the critique of the proposal and not the person.