4 ms·
"Proves a theory"? Karl Popper would like to have a word with them :)
by ggambetta 6y ago
"Proves a theory"? Karl Popper would like to have a word with them :)
- cassepipe 6y agoHey hum sorry to contact you here but I did not want to write to you on your acting address and I don't use Twitter. If I followed the math correctly I think there is a small mistake in the computation of diffused light at https://gabrielgambetta.com/computer-graphics-from-scratch/03-light.html#modeling-diffuse-reflection https://gabrielgambetta.com/computer-graphics-from-scratch/0... : In figure 3.5, the two triangles that are presented side by side are not the same. It follows I think that it is the cos of the Beta angle that should be used. Please correct me if I am wrong. Also let me thank you again for making it available as your method is very clear for a beginner and your explanations are good and straight to the point. I have sworn to myself I would buy the book by the time I finish implementing part 1 :)
- cassepipe 6y agoSorry not the cos of the Beta angle but rather the sin of the beta angle.
- cassepipe 6y agoOk sorry, I see how you are right and how I am wrong in thinking you were wrong. The figures I mentionned are indeed bit confusing though.
- ggambetta 6y agoHey, thanks for reaching out. As you've realized by yourself, the diagram is actually correct - but thanks for pointing out that it is confusing! The book is almost ready to go to print, but I'll see if this can still be fixed.