4 ms·

The commits actually do give that info. Take for instance this commit: https://github.com/git/git/commit/c8af66ab8ad7cd78557f0f9f5ef6a52fd46ee6dd#diff-fb446714

The commits actually do give that info. Take for instance this commit: https://github.com/git/git/commit/c8af66ab8ad7cd78557f0f9f5ef6a52fd46ee6dd#diff-fb44671421e652bbdc91bbe73b55da6547c851be1d604ce4d6c79b85a2e03654 https://github.com/git/git/commit/c8af66ab8ad7cd78557f0f9f5e... It actually gives examples and a lengthy explanation and reasoning behind the ban.

mamon 6y ago
But why put that info in commit message instead of a comment in the file itself?
- colordrops 6y ago
  Or even in the compile error message itself.
- chris_wot 6y ago
  Because comments can be tedious and get out of sync with the repo. Why not check the git history? I wish more repos could be like this!
  - adrianmonk 6y ago
    > Why not check the git history? Because that is effort every person who uses the file has to do over and over again, whereas maintaining the file is effort that has to be done once by one person.
    - chris_wot 6y ago
      It sounds like you want a manual. Personal preference I guess. The maintainers seem to have decided to keep it in the history. It's not like this was ever meant for anything other than git itself.
      - astrobe_ 6y ago
        If all you have is Git everything looks like a commit.
    - aendruk 6y ago
      I really wish tooling like this was more common: https://github.com/eamodio/vscode-gitlens/tree/v11.2.1#current-line-blame- https://github.com/eamodio/vscode-gitlens/tree/v11.2.1#curre... (screenshot) > Current Line Blame: Adds an unobtrusive, customizable, and themable, blame annotation at the end of the current line
    - skeletal88 6y ago
      Someone here commented to use git blame to find the commit that banned the functions and read the commits. These people making the suggestions.. must hate other people and their time. Also, what if someone.. for example runs a code formatter on the file, making git blame useless? Is it really so difficult to make a manual or explain properly in the comments about what replacements to use?
      - chris_wot 6y ago
        Try: git blame -w -M This will ignore whitespace and detect moved or copied lines.
      - ksherlock 6y ago
        git blame --ignore-rev / --ignore-revs-file
xorcist 6y ago
Now that's what a good commit message looks like!
- cesarb 6y ago
  Commit messages like that are common in the Linux kernel project, which is where git came from (though this particular commit message is a bit on the longer side). It makes more sense if you think of it as an email message justifying why the project maintainer should accept that change, because that's what they were before git even existed. Still today, unless you're one of the Linux kernel subsystem maintainers, you have to convert your changes to emails with git-format-patch/git-send-email and send them to the right mailing list. Even the Linux kernel subsystem maintainers keep writing commits in that style out of habit (and because Linus will rant at them if they don't).

mamon 6y ago

But why put that info in commit message instead of a comment in the file itself?

colordrops 6y ago
Or even in the compile error message itself.
chris_wot 6y ago
Because comments can be tedious and get out of sync with the repo. Why not check the git history? I wish more repos could be like this!
- adrianmonk 6y ago
  > Why not check the git history? Because that is effort every person who uses the file has to do over and over again, whereas maintaining the file is effort that has to be done once by one person.
  - chris_wot 6y ago
    It sounds like you want a manual. Personal preference I guess. The maintainers seem to have decided to keep it in the history. It's not like this was ever meant for anything other than git itself.
    - astrobe_ 6y ago
      If all you have is Git everything looks like a commit.
  - aendruk 6y ago
    I really wish tooling like this was more common: https://github.com/eamodio/vscode-gitlens/tree/v11.2.1#current-line-blame- https://github.com/eamodio/vscode-gitlens/tree/v11.2.1#curre... (screenshot) > Current Line Blame: Adds an unobtrusive, customizable, and themable, blame annotation at the end of the current line
  - skeletal88 6y ago
    Someone here commented to use git blame to find the commit that banned the functions and read the commits. These people making the suggestions.. must hate other people and their time. Also, what if someone.. for example runs a code formatter on the file, making git blame useless? Is it really so difficult to make a manual or explain properly in the comments about what replacements to use?
    - chris_wot 6y ago
      Try: git blame -w -M This will ignore whitespace and detect moved or copied lines.
    - ksherlock 6y ago
      git blame --ignore-rev / --ignore-revs-file

xorcist 6y ago

Now that's what a good commit message looks like!

cesarb 6y ago
Commit messages like that are common in the Linux kernel project, which is where git came from (though this particular commit message is a bit on the longer side). It makes more sense if you think of it as an email message justifying why the project maintainer should accept that change, because that's what they were before git even existed. Still today, unless you're one of the Linux kernel subsystem maintainers, you have to convert your changes to emails with git-format-patch/git-send-email and send them to the right mailing list. Even the Linux kernel subsystem maintainers keep writing commits in that style out of habit (and because Linus will rant at them if they don't).