3 ms·

You have to A/B test this though because who knows when somebody is in crunch and doesn't have time! Also, from a teammate perspective, it might be worth point

You have to A/B test this though because who knows when somebody is in crunch and doesn't have time! Also, from a teammate perspective, it might be worth pointing it out to the person. "I noticed a bug in the PR that I found later... want to show you why it could be a problem so we don't let it slip next time" Imo I usually just fire the PR off and message on Slack saying, "this one needs to ship ASAP, anything truly bjork'd here?" Or if it's going to be critical code, "The blast radius on this one is high. Give it a thorough scan please!" Communication is key :)

thebean11 6y ago
> I noticed a bug in the PR that I found later... want to show you why it could be a problem so we don't let it slip next time I don't know, that seems kind of confrontational. If I got called out for missing a bug in a review I'd be annoyed
- freeqaz 6y ago
  That's true, and it definitely can be! In my opinion, the best way to approach this situation is with "non-violent communication"[0] in mind. Don't make the conversation about "this is your fault, do better", instead make it about "I noticed a bug in my code that could have broken production and I think we can do better". It takes trust to pull off conversations like these without coming across as a prick. This type of empathy is particularly important when mentoring others because... People are always going to make mistakes. They create great opportunities to help somebody learn though. When I am being taught something, I learn much more quickly when somebody points to somewhere I failed versus explaining an "abstract" bad pattern. Maybe having the "abstract" idea first helps. It might make the "failure" easier to stomach later. For me though, those moments of stumbling always stuck as lessons I reflect back on the most. My attention to detail with code became a lot higher when I was on-call and prod broke at 4am because of a bug I let slip! 0: https://en.wikipedia.org/wiki/Nonviolent_Communication#Four_components https://en.wikipedia.org/wiki/Nonviolent_Communication#Four_...

thebean11 6y ago

> I noticed a bug in the PR that I found later... want to show you why it could be a problem so we don't let it slip next time I don't know, that seems kind of confrontational. If I got called out for missing a bug in a review I'd be annoyed

freeqaz 6y ago
That's true, and it definitely can be! In my opinion, the best way to approach this situation is with "non-violent communication"[0] in mind. Don't make the conversation about "this is your fault, do better", instead make it about "I noticed a bug in my code that could have broken production and I think we can do better". It takes trust to pull off conversations like these without coming across as a prick. This type of empathy is particularly important when mentoring others because... People are always going to make mistakes. They create great opportunities to help somebody learn though. When I am being taught something, I learn much more quickly when somebody points to somewhere I failed versus explaining an "abstract" bad pattern. Maybe having the "abstract" idea first helps. It might make the "failure" easier to stomach later. For me though, those moments of stumbling always stuck as lessons I reflect back on the most. My attention to detail with code became a lot higher when I was on-call and prod broke at 4am because of a bug I let slip! 0: https://en.wikipedia.org/wiki/Nonviolent_Communication#Four_components https://en.wikipedia.org/wiki/Nonviolent_Communication#Four_...