3 ms·
No, traditional code reviewing is just spot checking. That is analogous to having an editor only look at a few passages of a novel. An editor needs to work with
by gruseom 15y ago
No, traditional code reviewing is just spot checking. That is analogous to having an editor only look at a few passages of a novel. An editor needs to work with the whole text. This is the trouble with formal code reviews. Pair programming attempts to solve this by making all code get reviewed as it gets written. Like it or hate it, that at least tries to solve the core problem.
- mkjones 15y agoI suppose we're not "traditional" in this sense, but at Facebook we do somewhat more in-depth code reviews than just spot checking. Generally if you're modifying an existing system, you get one or two people who're familiar with that system (and thus know the big picture of code design, layout, etc) to review your diff. If you're writing something totally new, you usually throw ideas and mocks (either UI or code-structure) until you decide on a solution that works. I've found this to be pretty good at helping newer engineers write good (and idiomatic) code without hindering development speed much.