2 ms·
Code reviews turn into a formality when everyone is submitting great code. This is a good thing. BUT: I just joined a team with domain experts who do not have
by gwbas1c 6y ago
Code reviews turn into a formality when everyone is submitting great code. This is a good thing.
BUT: I just joined a team with domain experts who do not have a software engineering background. As I go through the code, there's lots of copy & paste, incorrect error handling, inconsistent (and confusing) variable names...
These developers really can benefit from coaching in a review. The team then benefits because the code is easier to read, robust, and maintainable.
(The codebase is impressive for people who have minimal software background. I've seen much worse from people who should know better.)