2 ms·
Early in my career, I learned so much from reviewing other more senior peoples' code. I suppose I technically did have "veto power" as my approval was required
by Gh0stRAT 6y ago
Early in my career, I learned so much from reviewing other more senior peoples' code.
I suppose I technically did have "veto power" as my approval was required in order to merge the PR, but nobody ever thought of it in such adversarial terms. We'd comment with questions or things that were unclear, occasionally asking "why are we doing it this way instead of that way?" and more often than not the solution was simply adding/updating comments to make things more clear.
For our team at least, it was a casual and collaborative effort where everyone learned from each other. I wouldn't hesitate to give inexperienced devs veto power over my PRs again unless it was for a time-sensitive hot-fix.