4 ms·
Bitwarden grants full remote access to your computer to the Bitwarden developers if you use the desktop app. https://github.com/bitwarden/desktop/issues/552 ht
by sneak 6y ago
Bitwarden grants full remote access to your computer to the Bitwarden developers if you use the desktop app.
https://github.com/bitwarden/desktop/issues/552 https://github.com/bitwarden/desktop/issues/552
The issue has been reported and they refuse to fix it.
This bug renders the Bitwarden encryption irrelevant, as the Bitwarden devs can always access your passwords regardless if they choose.
- codys 6y agoFor those just scanning the comments, "full remote access" is just being used to mean "has an automatic update system" here
- sneak 6y agoAn interaction-free automatic update system is, by definition, RCE, which is equivalent to full remote access. The Bitwarden devs can always access your passwords at any time if they choose to do so, as a result. This, to me, is as serious a vulnerability as lacking encryption in the first place.
- brigandish 6y agoHow do they decrypt the vault without the master password?
- sneak 6y agoBy replacing the client code with code that exfiltrates the password the next time you enter it. Alternately, brute forcing the client password is straightforward due to their use of a too-fast KDF and low iteration count. https://github.com/bitwarden/jslib/issues/52 https://github.com/bitwarden/jslib/issues/52 https://github.com/bitwarden/server/issues/589 https://github.com/bitwarden/server/issues/589
- brigandish 6y agoI agree that automatic updates should have a toggle, Signal desktop is another client where the devs won't provide one and have even taken egregious steps to prevent blocking it. Run in a reduced-privilege account though and either client will still require your assent via the admin rights to install. You're also right about the KDF but to be fair to them the devs say they'll accept work from a fork[0] to Argon2, if and when it's done (properly). [0] https://community.bitwarden.com/t/switch-to-argon2/350/24 https://community.bitwarden.com/t/switch-to-argon2/350/24
- gruez 6y agoHow do you feel about browsers or operating systems that are updated on a monthly/weekly basis? Do you not upgrade them ever? Do you set them to manual update but blindly accept all the updates? Or do you manually update only after performing a detailed code review of all the source code changes, along with doing a build yourself to make sure nothing malicious was slipped in?
- sneak 6y agoI disable automatic updates on all software on my machines, and update them periodically on a schedule, using downloads that are verified as authentic. I'm not sure where the rest of your questions come from. "Do you not upgrade them ever?" does not logically follow from being opposed to the major security vulnerability that no-interaction automatic binary modification poses.
- jeroenhd 6y agoThat's a very disingenuous way of putting it. If you use the application, there's auto update functionality (with a confirmation dialog box) if: - You're on Windows and not using the Windows Store version or a "portable" version of the application - You're on macOS and not using the app store version - You're on Linux and you're using the AppImage version Given the security-sensitive nature of the application and the target audience (mostly non-technical people), I think it's not a bad thing that this software has auto update functionality. If you want to be free of this behaviour, you can either install the application through your system package manager/app store so you can control the update behaviour there, or run a development build of your vetted version of the source code.
- sneak 6y agoIt doesn't have a confirmation dialog box, it simply notifies you that it has already happened. You can't easily prevent it. The vulnerability has already occurred by the time the dialog box is displayed. If you simply reboot your computer, the new code executes.
- jeroenhd 6y agoDoes it? From what I could tell from the source code, it seems like it should ask first. Even still, auto update is a feature, not a vulnerability. It's the only way to get non-technical people to patch their software because people are afraid of change. Even if there's a huge vulnerability in Bitwarden, tons of people won't click the "yes update please" button because they're afraid updates change the way the tool works or break something.
- sneak 6y ago> Even still, auto update is a feature, not a vulnerability. Autoupdate is fine, so long as it's opt-in. It is a massive vulnerability if not, amounting to the same control as a standard remote access toolkit: full RCE. > It's the only way to get non-technical people to patch their software because people are afraid of change. Not only is this a factually incorrect statement, it also contains a presumption that Bitwarden's developers have some right to decide for the end user what software runs on their computer, when the end user is the final authority, for better or worse, on what code is allowed to run on the hardware they own.
- Caligatio 6y agoYou should read your own bug report for the way to disable auto-updates: either use the portable version or set the ELECTRON_NO_UPDATER=1 environment variable.
- sneak 6y agoIt's easier to just chown the app to a user different than the one running it (so it can't self-modify) than it is to set env vars for GUI apps in macOS. I run a fork of the client now anyway, and bitwarden_rs on the server. I didn't want to deal with it but the dev responses to security reports are terrible.
- Caligatio 6y agoThere was a single dev response to your bug and it was the above solution. Your phrasing and tone are quite harsh as others in that bug commented and seemingly agreed by the community judging by the fact you got more thumbs down reactions than thumbs up. Combined with the fact you're not even a paying customer, you really need to evaluate whether your approach was appropriate.
- sneak 6y agoTruth isn't a popularity contest, unfortunately.