2 ms·
I also too a look at the code and wasn't impressed. Signal used to have a feature that allows you to import SMS. It had a few problems but it mostly did the jo
by GuB-42 6y ago
I also too a look at the code and wasn't impressed. Signal used to have a feature that allows you to import SMS.
It had a few problems but it mostly did the job. But lately, they disabled it with the latest onboarding update, without mentioning anything in the change log. I had to look at the git history to see that, I also found a "won't fix" ticket about the problem.
I think they are ignoring an very important feature but anyways, make a decision. Either you officially disable the feature, write it in the changelog and remove the dead code. Or you keep it and hopefully fix it. The way they are doing it is sloppy.
I didn't look too much into it but dead code is definitely a code smell and your experience seems to match mine. It is not terrible, but a bit underwhelming considered it is a highly regarded, security sensitive app.