4 ms·
The code review software I use at work lets reviewers add suggested edits that can be applied with a single click by the author of the commit. I try to use this
by iamevn 6y ago
The code review software I use at work lets reviewers add suggested edits that can be applied with a single click by the author of the commit. I try to use this as often as I can and mark any nits as non-blocking so they can still submit without another round trip if they decide against fixing for whatever reason.
I think nits are valuable but are absolutely not the focus of code review. Personally I'd rather see a few small nits on review of my code than just approval because that suggests the reviewer engaged with the code for more than just a quick glance.
- Jakobeha 6y agoThis is the way. There's nothing wrong with code reviewers correcting minor details, the issue is when said corrections waste the author's attention and time and slow PRs. If the edit is an easy bug-fix, the author should just look over it for a sec and approve. If it's a style change in some cases you don't even need the author to look at it.
- ris 6y agoThe "single click applied suggestion" thing of course doesn't work if you have a policy of avoiding trivial commits (actually a very good policy) and your PR is already about 3 or 4 commits. Then the author has to sit down, figure out which commit a change belongs to & do a `rebase -i` to squash together associated commits...