4 ms·
Thanks for this post. It’s very relatable. I started working around 5 years ago in a startup. I was a bloody beginner and we had someone joining who was pretty
by mgerullis 6y ago
Thanks for this post. It’s very relatable.
I started working around 5 years ago in a startup. I was a bloody beginner and we had someone joining who was pretty senior, who I suspect had OCD to some degree.
Being a startup we needed to ship, quickly.
That senior developer joining was working quite differently. He did not believe in auto-formatting, but he cared a lot about things which did not degrade the end product by the least bit.
E.g.: He had this super specific way of ordering CSS properties. It kinda made sense but I had to look it up every time and we did not have a linting rule for it.
He kept blocking PRs due to this, or a tiny typo in some comment. Being British he also kept correcting grammar.
He regularly found some extra breaking space or non-breaking space which was off. It meant that the PR is not gonna go through, until resolved.
Often, my PRs comment count would shoot past 50, at times even hundred, and I was becoming more and more desperate.
Today I tend to say: if it’s not lintable, it’s not a codestyle rule, and it’s been pretty great ever since.
- LilBytes 6y ago'He kept blocking PRs due to this, or a tiny typo in some comment. Being British he also kept correcting grammar.' Being British. I feel personally attacked. I assure you, his nationality had no correlation to his banal ways. Unless he was trying to correct your spelling of organization to organisatio which I can forgive.