3 ms·
Where I work, our code-review system allows anyone to push changes to any PR (provided they have permissions for the repo). It’s a great solution for people who
by dan-robertson 6y ago
Where I work, our code-review system allows anyone to push changes to any PR (provided they have permissions for the repo). It’s a great solution for people who have strong opinions on nit-picky things: they can just make trivial reasonable changes (eg rename a variable called x) instead of leaving a comment asking the author to make them. There’s obviously some middle ground like “I didn’t understand this function so I tried rewriting it: ... <new code> ... what do you think?” And it doesn’t work if you can’t have a good interaction with colleagues or if someone is too nitpicky. So it basically still works fine.
One funny issue I had was when two reviews each attempted to make what appeared to be a trivial change only to have the code fail to compile. We added a comment the second time.