4 ms·
Can't there be a build option to not use the LLVM submodule, and instead use the system LLVM? Assuming there are tests for these LLVM bugs, and assuming the pat
by cycloptic 6y ago
Can't there be a build option to not use the LLVM submodule, and instead use the system LLVM? Assuming there are tests for these LLVM bugs, and assuming the patches are indeed being merged, wouldn't a CI be able to catch when it is safe for downstream users that want to use upstream LLVM to update their Rust installation?
- steveklabnik 6y agoThere is. We even test that it builds as part of our CI, to make sure it works, IIRC.
- cycloptic 6y agoHmm, I couldn't find that last time I looked at building Rust -- all I saw was an option to grab precompiled builds of Rust LLVM from the CI server, but maybe I missed something.
- steveklabnik 6y agohttps://rustc-dev-guide.rust-lang.org/getting-started.html#configuring-the-compiler https://rustc-dev-guide.rust-lang.org/getting-started.html#c... links to https://rustc-dev-guide.rust-lang.org/building/suggested.html#skipping-llvm-build https://rustc-dev-guide.rust-lang.org/building/suggested.htm... ... which is broken. I'll file a docs bug. Can't do it right this moment, but will in a day or two. It is not my area of expertise, but I believe the way you do it is to set this option: https://github.com/rust-lang/rust/blob/master/config.toml.example#L596-L599 https://github.com/rust-lang/rust/blob/master/config.toml.ex... buuut the dockerfile for the llvm 9 build passes this flag as an argument: https://github.com/rust-lang/rust/blob/5a549d36ee81b226d16724240b88f0137f8a36af/src/ci/docker/host-x86_64/x86_64-gnu-llvm-9/Dockerfile#L31 https://github.com/rust-lang/rust/blob/5a549d36ee81b226d1672...
- drran 6y agoRust in Fedora is compiled with system LLVM (libLLVM-11.so). Enjoy.