3 ms·
> He doesn't necessarily view connections to Google servers that take place without explicit user intention/confirmation as problematic. I'd just go for his ow
by Youden 6y ago
> He doesn't necessarily view connections to Google servers that take place without explicit user intention/confirmation as problematic.
I'd just go for his own words [0] since they're so easily available.
> Based on his strong personality, I did not think it likely any patches I wrote would be accepted by him.
I think it's best to give him a chance rather than assume. From my interactions with him, he seems fairly open to contributions since as you've pointed out, he also seems overworked.
> packages/apps/Gallery/src/com/android/camera/MenuHelper.java (calls maps.google.com)
I think you're talking about [1], which only happens upon explicit user interaction (the user clicking a button to show on a map).
> packages/apps/Settings/src/com/android/RadioInfo.java (multiple connectivity checks pinging Google servers)
This code seems to be here [2] now and is only called as part of an on-click handler [3], so again, requires explicit user interaction. As far as I know, there isn't even a way to access the screen that triggers this. I did it manually (adb shell am start -n com.android.settings/.wifi.WifiStatusTest) and the UI makes it clear that clicking the button will cause network traffic to go to "www.google.com", as that hostname is listed explicitly in the UI.
> external/webrtc/webrtc/p2p/stunprober/main.cc
I think you're talking about [4], which is example code. When I was searching for it, I stubmled across Google's search tool [5], which I used to search for other references to those hostnames. There don't appear to be any outside of example code and unit tests.
> packages/apps/Nfc/src/com/android/nfc/P2pLinkManager.java (calls to the play store)
If you follow the code further, it appears that no network traffic is sent to the Play Store. The code just creates a Play Store URL for an app package, presumably when you try to share an app with someone over NFC.
> You can rationalize away each of these individually, but I was at 41 patches when I stopped (including changes that address Google connections that GrapheneOS acknowledges). The cockroach infestation analogy is pretty apt. They are everywhere, and if you try to follow the code to assess for severity, it will be hugely time-consuming, so unless you have a team developing the patches, the safest thing is to pre-emptively patch out.
But what exactly is everywhere? It'd be nice to get rid of the code you've mentioned but there are no connections to Google going out without user interaction. I'm not convinced that there's a problem here to be fixed.
[0]: https://github.com/GrapheneOS/os_issue_tracker/issues/96#issuecomment-511383707 https://github.com/GrapheneOS/os_issue_tracker/issues/96#iss...
[1]: https://android.googlesource.com/platform/packages/apps/Gallery/+/refs/heads/master/src/com/android/camera/MenuHelper.java#294 https://android.googlesource.com/platform/packages/apps/Gall...
[2]: https://github.com/GrapheneOS/platform_packages_apps_Settings/blob/11/src/com/android/settings/wifi/WifiStatusTest.java https://github.com/GrapheneOS/platform_packages_apps_Setting...
[3]: https://github.com/GrapheneOS/platform_packages_apps_Settings/blob/41d4b98e652e13393d39138027dfc9e9c30f43bf/src/com/android/settings/wifi/WifiStatusTest.java#L170-L173 https://github.com/GrapheneOS/platform_packages_apps_Setting...
[4]: https://chromium.googlesource.com/external/webrtc/+/HEAD/examples/stunprober/main.cc https://chromium.googlesource.com/external/webrtc/+/HEAD/exa...
[5]: https://cs.android.com/search?q=%22stun.l.google.com%22&ss=android%2Fplatform%2Fsuperproject https://cs.android.com/search?q=%22stun.l.google.com%22&ss=a...