3 ms·

Alexander Larsson did the lions share of the work on device mapper, and here are 29 PRs to show it (including the very first with the devicemapper label): http

by SEJeff 6y ago

Alexander Larsson did the lions share of the work on device mapper, and here are 29 PRs to show it (including the very first with the devicemapper label): https://github.com/moby/moby/pulls?page=2&q=is%3Apr+is%3Aclosed+author%3Aalexlarsson+label%3Aarea%2Fstorage%2Fdevicemapper https://github.com/moby/moby/pulls?page=2&q=is%3Apr+is%3Aclo... In fact, Solomon's own words from https://github.com/moby/moby/pull/2609 https://github.com/moby/moby/pull/2609 "Integrate lvm/devicemapper implementation by @alexlarsson into a driver", so unless you're more knowledgeable about the history than Solomon, I'm going to have to discount your take on this entire thing. Regardless, I think things are at a much better place now. It is unfortunate that there were tensions and more so that Solomon had such a tough time through it all. He's a super nice guy. But this is tech, and there will always be lots of personality conflicts. It is one of the precious few constants.

zapita 6y ago
It is absolutely not correct that Larsson did the lion’s share. What he did was implement a Go wrapper for libdevmapper, which exposes a very low-level API. It is the Docker team that implemented devmapper-based container storage, as well as the whole storage plugin system which was now required to support more than one storage method. The original devmapper lib is utterly undocumented and Larsson’s wrapper did not fix that. So getting that feature to work was an all-consuming task and it is the Docker team that did the bulk of it. You can see all this from the early history of the devmapper directory: https://github.com/alexlarsson/docker/commits/a14496ce891f1f09b10f0459550e8fe095b477b5?before=a14496ce891f1f09b10f0459550e8fe095b477b5+35&branch=a14496ce891f1f09b10f0459550e8fe095b477b5&path%5B%5D=devmapper https://github.com/alexlarsson/docker/commits/a14496ce891f1f...

by SEJeff 6y ago

zapita 6y ago

It is absolutely not correct that Larsson did the lion’s share. What he did was implement a Go wrapper for libdevmapper, which exposes a very low-level API. It is the Docker team that implemented devmapper-based container storage, as well as the whole storage plugin system which was now required to support more than one storage method. The original devmapper lib is utterly undocumented and Larsson’s wrapper did not fix that. So getting that feature to work was an all-consuming task and it is the Docker team that did the bulk of it. You can see all this from the early history of the devmapper directory: https://github.com/alexlarsson/docker/commits/a14496ce891f1f09b10f0459550e8fe095b477b5?before=a14496ce891f1f09b10f0459550e8fe095b477b5+35&branch=a14496ce891f1f09b10f0459550e8fe095b477b5&path%5B%5D=devmapper https://github.com/alexlarsson/docker/commits/a14496ce891f1f...