3 ms·
If you get 30k LoC PR you have a problem anyway. Did the author manually modify 30k LoC or is this result of some automated process? If it is for example a re
by lmilcin 6y ago
If you get 30k LoC PR you have a problem anyway.
Did the author manually modify 30k LoC or is this result of some automated process?
If it is for example a refactoring run from IDE (which is completely fine in itself), then the better way to handle it is to separate that single huge change into its own commit that explains how the change was generated.
For example, I insist that there are three categories of changes: reformats, refactors and functional changes and that commits can only contain single type of change and that it must be immediately apparent what type of change it is. So if you see 2k LoC reformat you skim over it and don't expect functional changes to be hiding.
On the other hand if the code is actual manual modifications it means somebody has spent a huge amount of work on it and it is not unreasonable that Code Review will take proportionally huge amount of work.
My longest Code Review took me a week and was for much smaller change in LoC than that.
There are probably better ways to handle a change like that. My preferred way is to pair up and assume that if two people actually worked on it, it is as good as a code review.
- bluGill 6y agoI agree with everything until your last paragraph. The people who did this massive thing over several weeks (I exaggerated the size a bit) have a lot of experience, but we don't trust them. They might have paired (though in these pandemic days I'm not sure how well that went), but the pair isn't seen as very good.