5 ms·

Thank you, really appreciate your work! I think FastAPI is the first serious contender to Flask, which is saying a lot. There is one thing though. It sounds sm

Thank you, really appreciate your work! I think FastAPI is the first serious contender to Flask, which is saying a lot. There is one thing though. It sounds small, but... Docs favicon is loaded from your webserver by default. I know telemetry helps, but not disclosing it and making it difficult to remove (believe me, it took me some time to do it) leaves a bad taste. Unnecessary, I would say, as the framework is impressive otherwise... I hope you reconsider this decision. Related issue: https://github.com/tiangolo/fastapi/issues/2518 https://github.com/tiangolo/fastapi/issues/2518 Regardless, thank you for creating and maintaining such an useful piece of software!

tiangolo 6y ago
I'm glad you like it! Hehe, there's no telemetry at all. It just points to the same docs' favicon (that is not even measured). Just to make a simple and easy to recognize UX. The same way JS and CSS for Swagger and ReDoc come from a JS CDN instead of forcing developers to figure out a way to serve those static assets. But anyway, if you want to remove the favicon from Swagger UI, it's also in the docs: https://fastapi.tiangolo.com/advanced/extending-openapi/#self-hosting-javascript-and-css-for-docs https://fastapi.tiangolo.com/advanced/extending-openapi/#sel...
- trulyme 6y ago
  Not sure we are talking about the same thing? The favicon is loaded from tiangolo.com server, not from the location of the docs? If there is no telemetry, then it's all the more important this got changed... But anyway, last thing I want to do is argue - as I said, I really appreciate your work! Really big thank you! :)
  - kowlo 6y ago
    That doesn't sound great. There is no reason the favicon should be loaded from tiangolo.com...
    - codefreakxff 6y ago
      There is NO reason? Not even that is where the FastAPI is hosted and is the developer’s website? You can’t think of any other examples of something linking to the product homepage?
      - deleted 6y ago
        [deleted]
  - tiangolo 6y ago
    Here's the favicon URL: https://fastapi.tiangolo.com/img/favicon.png https://fastapi.tiangolo.com/img/favicon.png The docs are here: https://fastapi.tiangolo.com/ https://fastapi.tiangolo.com/ Anyway, I'm glad FastAPI is being useful!

tiangolo 6y ago

I'm glad you like it! Hehe, there's no telemetry at all. It just points to the same docs' favicon (that is not even measured). Just to make a simple and easy to recognize UX. The same way JS and CSS for Swagger and ReDoc come from a JS CDN instead of forcing developers to figure out a way to serve those static assets. But anyway, if you want to remove the favicon from Swagger UI, it's also in the docs: https://fastapi.tiangolo.com/advanced/extending-openapi/#self-hosting-javascript-and-css-for-docs https://fastapi.tiangolo.com/advanced/extending-openapi/#sel...

trulyme 6y ago
Not sure we are talking about the same thing? The favicon is loaded from tiangolo.com server, not from the location of the docs? If there is no telemetry, then it's all the more important this got changed... But anyway, last thing I want to do is argue - as I said, I really appreciate your work! Really big thank you! :)
- kowlo 6y ago
  That doesn't sound great. There is no reason the favicon should be loaded from tiangolo.com...
  - codefreakxff 6y ago
    There is NO reason? Not even that is where the FastAPI is hosted and is the developer’s website? You can’t think of any other examples of something linking to the product homepage?
    - deleted 6y ago
      [deleted]
- tiangolo 6y ago
  Here's the favicon URL: https://fastapi.tiangolo.com/img/favicon.png https://fastapi.tiangolo.com/img/favicon.png The docs are here: https://fastapi.tiangolo.com/ https://fastapi.tiangolo.com/ Anyway, I'm glad FastAPI is being useful!