3 ms·
As far as I can see, the lock file for dependencies is not in the repository? That seems to be a grave mistake for mission critical software. You can expect it
by zelphirkalt 6y ago
As far as I can see, the lock file for dependencies is not in the repository? That seems to be a grave mistake for mission critical software. You can expect it to break at inconvenient moments. The installation instructions are merely `npm install`, so it is not reproducible work. I would not put too much weight in the label "nasa" on this one. Perhaps it is a low priority project for them, and it would not matter much, if it fails to build.
EDIT: The issues seem to confirm this. For example the demo app did not work out of the box. See /issues/3656
- dwers 6y agoI agree a source controlled package-lock file for reproducibility would be an improvement. As you alluded to, Open MCT in its current form would likely not be considered or used for mission critical purposes [1] but instead for planning, analysis, and general data visualization, as opposed to something like the AMPCS (AMMOS Mission Data Processing and Control System), which involves command/control and direct communication with a spacecraft. [1] Mission critical, meaning its operation is required to prevent any possible mission failure. https://nodis3.gsfc.nasa.gov/displayDir.cfm?Internal_ID=N_PR_8715_003D_&page_name=AppendixA https://nodis3.gsfc.nasa.gov/displayDir.cfm?Internal_ID=N_PR...