3 ms·
> simple one line changes can have profound and unexpected changes in correctness and performance. Small contributions typically required hours of my time to pr
by teddyh 6y ago
> simple one line changes can have profound and unexpected changes in correctness and performance. Small contributions typically required hours of my time to properly test and validate them.
Isn’t this a simple case of not having a good enough test suite?
- Jonnax 6y agoWell then why are they obligated to create a test suite?
- teddyh 6y agoHuh, what? Nobody is “obligated” to create a test suite. But they wrote that a simple change could take hours to review. Creating a test suite might pay for itself (time-wise, that is) in the long run, if they want to accept external patches. Having patch reviews take hours is not the only option.