3 ms·
This is a good _start_ but nowhere near being sufficient for reducing workload of reviewing PRs. If a patch is a bugfix then clearly none of the past tests cau
by jabbany 6y ago
This is a good _start_ but nowhere near being sufficient for reducing workload of reviewing PRs.
If a patch is a bugfix then clearly none of the past tests caught the bug <_<...
If the patch is a new feature then it will certainly need new tests to validate its own behavior is correct...
- cbm-vic-20 6y agoIf a patch is a bugfix, it should include a test that fails before the patch, but passes after the patch (along with all of the other tests).
- jabbany 6y agoYes, the idea is that the effort isn't really eliminated. It's just shifted from reviewing the code to reviewing the new tests, which sometimes can be just as hard as reviewing the code when complex bugs are involved.