4 ms·

I took a quick look at the contributor graph: https://github.com/vim/vim/graphs/contributors https://github.com/vim/vim/graphs/contributors Other than one sol

by jwatt 6y ago

I took a quick look at the contributor graph: https://github.com/vim/vim/graphs/contributors https://github.com/vim/vim/graphs/contributors Other than one solitary commit, that graph makes it look like every single one of the 13,000 commits to Vim has been made by Bram. What's going on there? Incidentally I wondered what caused the huge jump in commits that has been sustained since the beginning of 2016. I thought initially that may have coincided with the announcement of Neovim, but that announcement seems to have been a couple of years earlier. Maybe it took a couple of years for Neovim to see significant adoption though.

monkin 6y ago
Patches are send to mailing list, and Bram commits them do repository after review. Each contribution is credited in commit message, and VIM docs. I like this approach better than GitHub “everyone send us a PR”. These days having a “change a typo” PR to show activity on GitHub is appealing to masses, but mailing list sifts out people who don’t have anything serious to add = less work in managing open source project. As we can see lot’s of maintainers have a problem with that, and users that demand stuff (at least once a month there’s a topic about it on HN). :-)
- jwatt 6y ago
  Thank you. Having a mailing list based workflow is fairly common for long established projects. That doesn't seem to preclude setting the Author field to the actual author when Bram lands people's contributions though. Unless that's an additional layer to discourage low value contributions by eliminating the visible credit people would get in their github commit history. Are there other projects that do that?
  - monkin 6y ago
    As I mention before, each of contributions is credited on GitHub commits, and VIM docs. So you still can showcase those in your portfolio, by writing case study or short information as it was before GitHub... :-)

by jwatt 6y ago

monkin 6y ago

Patches are send to mailing list, and Bram commits them do repository after review. Each contribution is credited in commit message, and VIM docs. I like this approach better than GitHub “everyone send us a PR”. These days having a “change a typo” PR to show activity on GitHub is appealing to masses, but mailing list sifts out people who don’t have anything serious to add = less work in managing open source project. As we can see lot’s of maintainers have a problem with that, and users that demand stuff (at least once a month there’s a topic about it on HN). :-)

jwatt 6y ago
Thank you. Having a mailing list based workflow is fairly common for long established projects. That doesn't seem to preclude setting the Author field to the actual author when Bram lands people's contributions though. Unless that's an additional layer to discourage low value contributions by eliminating the visible credit people would get in their github commit history. Are there other projects that do that?
- monkin 6y ago
  As I mention before, each of contributions is credited on GitHub commits, and VIM docs. So you still can showcase those in your portfolio, by writing case study or short information as it was before GitHub... :-)