4 ms·
Hi! What is wrong with github's code review? You means the pull requests?
by vickodin 6y ago
Hi! What is wrong with github's code review? You means the pull requests?
- habosa 6y agoYes I mean the process of reviewing a Pull Request, especially a complex one with multiple rounds of feedback. Some major issues, in my opinion: * The review is spread over 4 tabs, with "Conversation" being the default and "Files" being the 4th even though "Files" is clearly the most important * Comments can become "outdated" and lost as code changes even if they were still relevant * There are too many ways to do one thing. "Leave a comment" vs. "Start a review". "Comment" vs "Request Changes". "Requested reviewers" vs. "Assignees", etc. It's all built up over time into a bit of a mess. So ... I think I can do better! And I think I can do it in a way that's easy to layer on top of GitHub so that teams can still enjoy all of the other amazing things about developing code there.