3 ms·
As far as I've seen, Signal don't really accept outside contributions. I'm not sure if it's policy, or just a culture thing. They may have accepted some in the
by lucideer 6y ago
As far as I've seen, Signal don't really accept outside contributions. I'm not sure if it's policy, or just a culture thing.
They may have accepted some in the past, but I've never seen it, and I've seen a lot of PRs closed unmerged.
- asddubs 6y agochecked the last 10 closed pull requests -1 closed by the author realizing it had already been done -2 closed saying they were going to fix it differently -1 closed saying they took some code from the commit and fixed part of it differently -6 merged seems quite reasonable to me (albeit this is only from the newest 10 closed pr obviously)
- lucideer 6y agoYour 2nd & 3rd examples I've seen a fair bit of, but I've mostly seen them closed due to the feature not lining up with Signal devs' intent. Glad to hear this seems to be changing; 6/10 is pretty good.