4 ms·
I will talk about accepting outside contributions in a general sense (beyond JS and Julia comparisons). In my personal experience, the acceptance rates doesn't
by zinekeller 6y ago
I will talk about accepting outside contributions in a general sense (beyond JS and Julia comparisons).
In my personal experience, the acceptance rates doesn't really matter and does not correlate to the quality of the code. On one hand, you have SQLite which really discourages direct code submissions due to the nature of the IP management of SQLite (they need to ensure that it is 100% in public domain), instead relying on bug reports instead. SQLite however is a very good product, something that I personally miss when I work on JS projects.
On the other hand, I've seen projects (multiple, which I prefer not naming to prevent flame wars) with very high acceptance rates - the problem is that the coding style and availability of comments are inconsistent to the point that we have to forego using some libraries and writing our own despite those libraries will fit into the bill nicely.
Edit: some have commented "this is what I've expected!", but there are some projects (obviously will be unnamed) that are not accepting contributions but the code consistency is less-than-ideal, and some projects with well-behaved outside contributors that have kept the quality despite having high acceptance rates (usually writing in relatively niche languages). Probably the area I'm working on (educational) isn't reflective on the wider community, which seems to associate higher rejection rates to quality.
- gieksosz 6y agoOn top of that some repos, like Bazel for instance close all PRs and import them via a process which happens outside GitHub. Some repositories do not use GitHub organisations at all, other do it a lot - those factors make merge-chance.info analysis more difficult, but I still think it is interesting. I hope it might even help someone chose what project to contribute to.
- zinekeller 6y agoI think that if you want to contribute, they should at least be upfront on the processes, or even the absence of it. Some do not accept at all, some do only accept on bugfixes, and some are happy to extend the project. The chance of merging of course is a decent barometer for contributors who wants to work on projects who are allegedly open to contributions, but I will not use it as a barometer of the quality of the code itself (or at least as a minor barometer - never as a major one).
- remram 6y agoThis might be on GitHub more than maintainers, as there is no option to disable the pull requests feature right now (or to replace it with a link to what you actually use).
- ithrow 6y agoWhy can't you use sqlite in js projects?
- wffurr 6y agoGP misses the quality of engineering that goes into sqlite when dealing with JS projects.
- 411111111111111 6y agoYou can only use it with node I believe? At least I would prefer to use sqlite over indexeddb, but haven't found a way yet.
- young_unixer 6y agoYou say acceptance rate doesn't correlate with code quality and then you give 2 data points where it does correlate in the expected way.
- santoshalper 6y agoHe's playing the long con.
- zinekeller 6y agoAdded remarks. Probably the area I'm working on (educational) isn't reflective on the wider community, which seems to associate higher rejection rates to quality.
- darkerside 6y agoI'm confused. My intuition is that the lower the acceptance rate, the higher the code quality would be. It demonstrates high standards.
- zinekeller 6y agoAdded remarks. Probably the area I'm working on (educational) isn't reflective on the wider community, which seems to associate higher rejection rates to quality.