4 ms·

I wouldn't call an accuracy-performance tradeoff a bug, rather a design decision

• alisonkisk 6y ago
  No one is running sloc a million times per second. The performance cost here is trivial.
  • ashutoshgngwr 6y ago
    No, but you usually run it on a complete codebase which can be humongous.
    • mmmeff 6y ago
      Humongous what?
      • ashutoshgngwr 6y ago
        ..in source size. What I meant was while for a single source file, performance implications aren't noticeable. But usually when we run a tool like this, we happen to do it on an entire project, e.g. imagine running it on Kubernetes repo. If it were to parse entire syntax trees, the performance implications would be significant.
  • proto-n 6y ago
    The accuracy cost is trivial as well, it's a trade-off. I'm pretty sure the implementers were fully aware that regex can't properly handle every case and decided not to care.