4 ms·

I was curious as well, turns out they're using a non-standard parsing with a comment in the function explaining why: /* This uses a non-standard parsing (i

I was curious as well, turns out they're using a non-standard parsing with a comment in the function explaining why: /* This uses a non-standard parsing (ie not inet_aton, or inet_pton) * because of legacy choice to parse 10.8 as 10.8.0.0 not 10.0.0.8 */ src: https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/lib/utils.c#n450 https://git.kernel.org/pub/scm/network/iproute2/iproute2.git... (the entry point to start tracing down to the above inner function is right around here: https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/ip/iproute.c#n2058 https://git.kernel.org/pub/scm/network/iproute2/iproute2.git... )

j1elo 6y ago
Conclusion: explicit is better than implicit, and what's more, in this case the implicit alternative was depending on a non-standard choice made in the specific tool for obscure, legacy reasons.
- gravitas 6y ago
  This fits almost any situation (explicit vs. implicit) and I'm a big fan - when mentoring I tend to say "yes that was the default when you looked today, how do you know it won't change tomorrow? If you want specific behaviour, be explicit don't trust defaults." (more or less, depends on subject - commandline switches to code loops, same advice)