4 ms·
Equal => return Some(key), The article's implementations return the index, not the value being searched for as you've done here. Do slices give access to thei
by klyrs 6y ago
Equal => return Some(key),
The article's implementations return the index, not the value being searched for as you've done here. Do slices give access to their underlying offset?
Also the article manages a single branch per iteration. How well does this cmp / match perform in comparison?
- __s 6y agoFor reference, this is rust's actual binary search implementation: https://doc.rust-lang.org/src/core/slice/mod.rs.html#1841 https://doc.rust-lang.org/src/core/slice/mod.rs.html#1841 (returns either Ok(index) when element exists, or Err(index) where index is where you'd insert the element when it doesn't exist)
- tsimionescu 6y ago> Do slices give access to their underlying offset? They don't have to, you already have `middle` available, they can just return Some(middle)
- klyrs 6y agoNo, middle is an index into a slice with an arbitrary offset. Unless (with probability ≈ 0.5^log(n)) you've picked the lower half every time before finding the element, that is not the correct index.
- tsimionescu 6y agoOops, you're absolutely right. I completely forgot that the array variable was being modified itself.
- deleted 6y ago[deleted]