5 ms·

http-parser is based on parsers from mongrel and/or nginx (at least in parts), yet the LICENSE file says Joyent, Inc. and other Node contributors.... No mention

http-parser is based on parsers from mongrel and/or nginx (at least in parts), yet the LICENSE file says Joyent, Inc. and other Node contributors.... No mention of the original copyright holders (Zed Shaw and/or Igor Sysoev) tsk tsk

bnoordhuis 15y ago
There isn't a shred of the original mongrel parser left. I'm not 100% sure but http-parser looks more like it's inspired by nginx than that it actually contains nginx code. Disclosure: I know both http-parser and nginx fairly well. I'm one of the 'other Node contributors'. :-)
- piotrSikora 15y ago
  But it was Ryan who said that it does: http://twitter.com/#!/ryah/status/69620659650699264 http://twitter.com/#!/ryah/status/69620659650699264
  - notJim 15y ago
    If you read to the bottom of the email chain here: http://twitter.com/#!/ryah/status/69624489893314560 http://twitter.com/#!/ryah/status/69624489893314560, ry says he rewrote the parser.
    - piotrSikora 15y ago
      You've missed the fact that this e-mail is from 2009 and tweet is from yesterday. Surely a lot changed in the meantime. Anyway, Igor Sysoev was just added to the LICENSE file, so EOT.
orls 15y ago
The NGINX contribution has been noted now; https://github.com/ry/http-parser/commit/8dabce6ec7142319bc5c883ff53bf7302f0d83ce https://github.com/ry/http-parser/commit/8dabce6ec7142319bc5...
- piotrSikora 15y ago
  Thank you.