5 ms·

It should be pushd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 not cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 with a matching popd at the end O

It should be pushd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 not cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 with a matching popd at the end Otherwise it can screw up parent scripts

Galanwe 6y ago
Not unless the script is source'd, which is very unlikely.
dastx 6y ago
Really scripts should avoid called `cd` or `pushd`/`popd` wherever possible. It's a lot better to just work with absolute directories, i.e. as someone else pointed out: DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
- Brian_K_White 6y ago
  no no no... god this is gross and awful SELF=${0##*/} # aka basename DIR=${0%/*} # aka dirname
  - dastx 6y ago
    Running a script as sh script.sh returns only script.sh, thus, you've already got SELF, but you wouldn't get DIR.
    - cat199 6y ago
      but, you don't need it since you are already there, and can just use $PWD (no need for `pwd`) from that point onward.