10 ms·
Nice to see but it's too contrast-y for me compared to the stylus theme I've already been using which honestly looks better https://github.com/StylishThemes/Git
by deadmik3 6y ago
Nice to see but it's too contrast-y for me compared to the stylus theme I've already been using which honestly looks better https://github.com/StylishThemes/GitHub-Dark https://github.com/StylishThemes/GitHub-Dark
- bnt 6y agoThis feels more inline with Windows Dark Mode (since Github is a Microsoft company).
- ksec 6y agoWell since the Settings has both System Default and Dark Mode, I wish System Default would be matching closer to macOS Dark Mode which is Dark Greyish colour when user is on macOS.
- SquareWheel 6y agoSystem Default likely just infers dark mode preference via prefers-color-scheme. It doesn't seem to be a unique theme.
- abdusco 6y agoIn case anyone's interested, it's possible to schedule light and dark themes on Windows via this app: https://github.com/adrianmteo/Luna https://github.com/adrianmteo/Luna I usually prefer the dark theme but some websites detect that Windows is in dark mode (using `prefers-color-scheme: dark` in CSS) and fail to provide a way to toggle the dark theme off. This makes it difficult to read the text during daytime. Scheduling dark theme on & off and combining it with Dark Reader's automation, it's nice being able to have all websites switch to dark mode at night.
- Zarel 6y agoHow do you combine it with Dark Reader's automation? I don't see any automation option in Dark Reader. :(
- abdusco 6y agoDark Reader settings > Dev Tools > Switch to new Design then Dark Reader settings > automation > use system color theme
- desmap 6y agoI found https://github.com/Armin2208/Windows-Auto-Night-Mode https://github.com/Armin2208/Windows-Auto-Night-Mode to be better for auto-scheduling.
- da_big_ghey 6y agoI believe the CEO stated an intention to add more themes for, say, colorblind people, so there might be additional options coming. Edit: Found the link. https://twitter.com/natfriedman/status/1330924323952091137 https://twitter.com/natfriedman/status/1330924323952091137
- bluefox 6y agoGitHub have the gall talking about accessibility while flinging their octotentacles, dragging users screaming down to the firey pits of JavaScript hell.
- viraptor 6y agoWhat are the actual issues? JS does not necessarily mean lack of accessibility on its own.
- bluefox 6y agohttps://news.ycombinator.com/item?id=25076987 https://news.ycombinator.com/item?id=25076987
- viraptor 6y agoAccessibility doesn't really mean catering to people who choose to disable JS in their browser. There's whole set of standards for providing accessibility with dynamic web https://www.w3.org/WAI/standards-guidelines/aria/ https://www.w3.org/WAI/standards-guidelines/aria/
- bluefox 6y agoSays you.
- viraptor 6y agoAnd every common description of web accessibility. From WAI to Wikipedia to common courses. I'm not saying it's good design or the right direction for GitHub. Just that accessibility is important and disabling-js is not really it. Specifically: disabling JS - your choice; having a disability - not your choice.
- GordonS 6y agoI've been using a Firefox plugin that let's you style sites with alternative CSS for years to achieve something similar on GitHub (I forget the name, but it is pretty popular) - every now and then something on the site looks a bit weird until the styles are updated to keep in sync with GitHub tho. I personally think GitHub have got this just right, I love it! (I'm red/green colour blind tho, and do tend towards preferring a bit more contrast).
- rurp 6y agoI use the Dark Reader plugin on Firefox and it is incredible. It works perfectly on almost all sites, which is quite an accomplishment given how many site-specific dark modes are either poorly done or non-existent.
- SkyPuncher 6y agoYea, I just tried it too. WOW that is hard on my eyes. It feels move like "invert colors" than a dark theme. Toning the white down would be a huge improvement.
- mssundaram 6y agoSame! I use Dark Reader and I much prefer it's take on Github than this - way too much contrast. "Dark" doesn't need to mean BLACK. A nice example is overreacted.io - a navy/blue dark theme.
- prathiks 6y agoI completely agree. the current one is tough to read
- mr_custard 6y agoAgree - This GitHub theme is unfortunately too dark. Which is a shame, because I was genuinely excited to read that GH has released a dark mode. I use many dark mode themes and have even created them. The important thing to constantly keep in mind whilst authoring a dark them is: resist the urge to go "too dark" and contrasty, and to keep checking against a known "good" reference. If any GitHub execs are reading this, and would like to see an example of what we're talking about here, then the JetBrains "Darkula" theme in IntelliJ is a well done dark theme.
- WhoCaresLies 6y agoI agree, on top of that you can change the syntax coloring with the stylus theme They had years to build a dark theme, and they managed to under deliver.. They should have just forked the stylus theme..
- suyash 6y agoyes, I would like few different options for dark theme
- prathiks 6y agoI actually think they have less contrast. I am having trouble reading the text
- HeavyStorm 6y agoFor amoled users the real black background is a blessing. On my phone it looks great. But I use gh on my desktop, a not my phone. A LCD friendly mode is a must.