3 ms·
This is some great advice, although I'm not completely sold on number 8 and number 9. For number eight: If your reviewer is being a douche, I don't think there
by luord 6y ago
This is some great advice, although I'm not completely sold on number 8 and number 9.
For number eight: If your reviewer is being a douche, I don't think there's harm in pointing it out, respectfully. Nothing says that both sides can't learn from the review.
As for number nine. I'm not sure if adding comments is going to completely help; I'd rather refactor to make the code as explicit as possible, including the tests[1]. But more importantly, I don't think that sacrificing possibly more idiomatic code for the sake of beginners is a great trade-off. I think it's better to encourage people to get more familiar with the language and technology being used.
[1]: Which is usually my first stop for when I might not understand something in the code itself.