3 ms·
> Nothing takes my motivation for contributing away as a reviewer that just must find something to complain about the code. Or the reviewer that always asks fo
by zests 6y ago
> Nothing takes my motivation for contributing away as a reviewer that just must find something to complain about the code.
Or the reviewer that always asks for more tests. (Once I got asked to write a test that was unnecessary and almost impossible to write a test for. Think timing issues. My options were to push back or spend a significant amount of time writing a test that was not needed. As a junior that already pushed back more than a typical junior I made the best choice I thought I could make at the time.)
- aequitas 6y agoWhat really helps in the case of testing is lead by example. If the project itself provides a good test framework and examples of properly implemented tests it is easy for contributors to add tests as well. But asking people to figure this stuff out themselves is often a really big hurdle. Also parametrized tests. I find no shame in asking people to add a case to a existing parameterized testsuite when submitting an issue.