3 ms·
No problem I understand, it took me a while before I ended up sticking with (1). I still think it's much easier for the author to make those changes, and attac
by nullandvoid 6y ago
No problem I understand, it took me a while before I ended up sticking with (1).
I still think it's much easier for the author to make those changes, and attach a commit ID to the relevant comment, than it is the other way around.
As the article states, respect the code reviewers time. If i've put in some effort to point out issues, and you don't even spend the effort to address each comment individually, then you are not respecting the reviewers time.
Maybe there are some cases you are right, but as a general rule i'll just always follow (1) as an author, as it honestly doesn't cost me much time, and makes my reviewers life easier.