3 ms·
I'm not sure this is controversial so much as it is just terrible advice! Are you really suggesting that developers purposely introduce bugs into a code base j
by adamkl 6y ago
I'm not sure this is controversial so much as it is just terrible advice!
Are you really suggesting that developers purposely introduce bugs into a code base just to keep reviewers on their toes?
It may seem like a relatively harmless idea in the small, but in the large, imagine hundreds or thousands of developers taking this advice, and purposely committing bugs. Yikes.
- alisonkisk 6y agoNo one said to commit bugs.
- adamkl 6y agoIf it's in a code review, it's been committed to some branch in source control. If it makes it past the code review, it's now a part of your product. If people want to use this approach as a training exercise (as mtlynch suggested in a sibling post), that's one thing, but that's not what OP suggested, and what OP suggested seems like pretty risky advice.
- plorkyeran 6y agoIf the deliberate mistake makes it past code review then you just remove it before merging anyway. A workflow where you are not allowed to fix anything in your own PRs before merging them unless they are explicitly requested by a reviewer would be very strange.