4 ms·
I might be alone in feeling this way, but when I see "team lead" and "a big part of my job is doing code reviews", it raises a red flag for me. Is feels like "
by kevsim 6y ago
I might be alone in feeling this way, but when I see "team lead" and "a big part of my job is doing code reviews", it raises a red flag for me.
Is feels like "the boss" who is "approving" code before it gets merged in.
In any team I've been a part of, I want the tech lead contributing by writing code, doing design, etc. and I want everyone reviewing code, not everything piling onto one person.
- matt_the_bass 6y agoYeah. On my team the code writer “arbitrarily” assigns the code review to anyone else on the team with the intent of assigning to someone with domain experience related to the topic or who wants to get more familiar with it. Though one person may write the code, it’s rare that any code was developed solo in a vacuum. So that other person (or people) are obvious candidates to be selected. Most of us lurk on all PRs so anyone can also chime in if something jumps out at them. Obviously most won’t lurk on code details but will lurk/chime in on strategy discussion or assumptions. This works best when there is a well written PR description.