4 ms·

Here's this page with no JS. https://remove-js.com/https://news.ycombinator.com/item?id=25276193 https://remove-js.com/https://news.ycombinator.com/item?id=2...

by josho 6y ago

Here's this page with no JS. https://remove-js.com/https://news.ycombinator.com/item?id=25276193 https://remove-js.com/https://news.ycombinator.com/item?id=2... CSS seems to break somewhat. Does hacker news rely on JS for CSS styling?

doctorOb 6y ago
No, seems more like remove-js and hacker news aren't playing well together. HN reference's it's one stylesheet relatively, so the remove-js output builds an invalid URL like this: https://news.ycombinator.com/item?id=25276193/news.css?7xnRK0pv8n1Oh7woNqhn https://news.ycombinator.com/item?id=25276193/news.css?7xnRK...
chrismorgan 6y ago
Nah, it’s just not joining URLs correctly, and so is trying to load the wrong stylesheet: Base URL: https://news.ycombinator.com/item?id=25276193 Relative URL: news.css?7xnRK0pv8n1Oh7woNqhn Correct resolved URL: https://news.ycombinator.com/news.css?7xnRK0pv8n1Oh7woNqhn Actual resolved URL: https://news.ycombinator.com/item?id=25276193/news.css?7xnRK0pv8n1Oh7woNqhn
- steviedotboston 6y ago
  Good catch! I'll try to fix this one
  - chrismorgan 6y ago
    Two things to make sure you’re doing: • Parse according to the URL Standard: https://url.spec.whatwg.org/ https://url.spec.whatwg.org/ • Use the correct base URL: https://html.spec.whatwg.org/#document-base-url; https://html.spec.whatwg.org/#document-base-url; this means largely “take the first base element with an href attribute, if it exists; if so, resolve its href attribute relative to the document URL; otherwise, use the document URL”.
hanniabu 6y ago
How does HN know where in the page to bring you back to after you submit a comment?
- shakna 6y ago
  The comment ID that you're replying to is included in the reply button. For example, yours looks like: reply?id=25277197&goto=item%3Fid%3D25276193%2325277197 Note the id element. Then, notice that the span that appears immediately before your comment has an ID too: unv_25277197. With those two pieces, adding a URI fragment is enough to get back to the right place.

by josho 6y ago

doctorOb 6y ago

No, seems more like remove-js and hacker news aren't playing well together. HN reference's it's one stylesheet relatively, so the remove-js output builds an invalid URL like this: https://news.ycombinator.com/item?id=25276193/news.css?7xnRK0pv8n1Oh7woNqhn https://news.ycombinator.com/item?id=25276193/news.css?7xnRK...

chrismorgan 6y ago

Nah, it’s just not joining URLs correctly, and so is trying to load the wrong stylesheet: Base URL: https://news.ycombinator.com/item?id=25276193 Relative URL: news.css?7xnRK0pv8n1Oh7woNqhn Correct resolved URL: https://news.ycombinator.com/news.css?7xnRK0pv8n1Oh7woNqhn Actual resolved URL: https://news.ycombinator.com/item?id=25276193/news.css?7xnRK0pv8n1Oh7woNqhn

steviedotboston 6y ago
Good catch! I'll try to fix this one
- chrismorgan 6y ago
  Two things to make sure you’re doing: • Parse according to the URL Standard: https://url.spec.whatwg.org/ https://url.spec.whatwg.org/ • Use the correct base URL: https://html.spec.whatwg.org/#document-base-url; https://html.spec.whatwg.org/#document-base-url; this means largely “take the first base element with an href attribute, if it exists; if so, resolve its href attribute relative to the document URL; otherwise, use the document URL”.

hanniabu 6y ago

How does HN know where in the page to bring you back to after you submit a comment?

shakna 6y ago
The comment ID that you're replying to is included in the reply button. For example, yours looks like: reply?id=25277197&goto=item%3Fid%3D25276193%2325277197 Note the id element. Then, notice that the span that appears immediately before your comment has an ID too: unv_25277197. With those two pieces, adding a URI fragment is enough to get back to the right place.