2 ms·
A few points, you need to judge how well they apply to your situation and your relationship with the coworkers: a) have you discussed the expectations on your
by detaro 6y ago
A few points, you need to judge how well they apply to your situation and your relationship with the coworkers:
a) have you discussed the expectations on your code review (and the time it takes)? A clear "take the time you need" or "focus on bits that look critical" might answer that. (Certainly many places would be fine with someone new taking time to understand what's going on, but if you are worried it might be good to get clarification on that)
b) similar, what kind of focus do they expect from code review? E.g. I know places that take stylistic things very seriously, and others don't at all. Stylistic stuff is on one hand more to think about, but also an easy place to show "yes, I'm reviewing this".
c) Asking people to change their workflow is always a bit tricky, but if you think it helps maybe you could ask for more smaller MRs - that makes changes easier to think through properly IMHO.
d) are the changes missing context for you to understand? "I don't get why this is correct, can you please expand the comments/commit message" is IMHO valid feedback.
e) hopefully as you learn more about the structure you can prioritize yourself better, e.g. by recognizing that changes fit established patterns and don't need as much attention.