6 ms·

Dark Mode Coming to GitHub After 7 Years

44 points by whack 6y ago

njhaveri 6y ago
Finally! Hopefully it will be based on the prefers-color-scheme media feature, instead of it being a setting to toggle…
bamboleo 6y ago
After 7 years of what? 7 years since someone opened a random issue on a random repo?
- sm4rk0 6y ago
  From another perspective: Isn't it ironic that GitHub doesn't publicly expose it's own /issues? Like GitLab does: https://gitlab.com/gitlab-org/gitlab/-/issues https://gitlab.com/gitlab-org/gitlab/-/issues If they did, we wouldn't have to rely on random issues on random repos.
  - bamboleo 6y ago
    From the page you linked: Issue 789719, that’s why.
    - sm4rk0 6y ago
      I don't get it... The latest issue I see there is #289797. Even if #789719 was a typo, I'm logged in but still getting a 404 for #289719. Maybe that's a private issue visible to you? Or your point is the sheer number of issues?
joshxyz 6y ago
Im worried on how it will go well with colours of issue labels. Exciting still <3
gfxgirl 6y ago
Dark mode has big issues with use generated content. you make a logo, diagram, or screenshot for your README, you can't make it dark/light compatible.
- chrismorgan 6y ago
  So long as the <picture> and <source> tags and the media attribute are whitelisted, you can do this: <picture> <source src=screenshot-dark.png media="(prefers-color-scheme: dark)"> <img src=screenshot-light.png> </picture> And then if the site is doing dark mode toggling by some means other than `@media (prefers-color-scheme: dark)`, it can go through and rewrite the media queries in all user-generated content, e.g. to change that one to media="all" in dark mode or media="not all" in light mode.
  - deleted 6y ago
    [deleted]
SeeDave 6y ago
Perhaps I'm missing something here, or may be an arrogant internet neckbeard, but I'm always confused as to why people are often so eager/excited by dark mode (e.g. Slack around a year ago, or GitHub today) Isn't the implementation of 'Dark Mode' little more than a CSS Color palette and a toggle switch nested somewhere in user settings? Are people celebrating the usability over the technical feat? Seems like much ado about nothing :/
- npteljes 6y ago
  I completely agree, not to mention the questionable merits of dark mode in general. There are numerous third party solutions too, if someone really wanted them. I wish open standards were this popular.
  - Can_Not 6y ago
    > questionable merits of dark mode in general I'm confused about what you find questionable about this, are you saying we shouldn't accommodate people with disabilities?
    - npteljes 6y ago
      Dark mode, besides looking cool, is sometimes promoted as healthier to the eyes, or using less energy to display the same content. These are the claims I think are questionable. The accessible color features will be cool.
      - spicybright 6y ago
        I like dark mode because it looks better, health claims or not.
- gedy 6y ago
  Yes it should be, but seems the reality is many sites and apps hardcode colors and don't have great separation of presentation from color. Many designers and product people have a hard time getting their head around views that might not look the same and to design for the content, not the picture, etc.
lumberingjack 6y ago
Hacker news used to be less waste of my time than it is now all of a sudden the liberals pile in and we got weird ass stupid stories that don't even matter voted to the top

44 points by whack 6y ago

njhaveri 6y ago

Finally! Hopefully it will be based on the prefers-color-scheme media feature, instead of it being a setting to toggle…

bamboleo 6y ago

After 7 years of what? 7 years since someone opened a random issue on a random repo?

sm4rk0 6y ago
From another perspective: Isn't it ironic that GitHub doesn't publicly expose it's own /issues? Like GitLab does: https://gitlab.com/gitlab-org/gitlab/-/issues https://gitlab.com/gitlab-org/gitlab/-/issues If they did, we wouldn't have to rely on random issues on random repos.
- bamboleo 6y ago
  From the page you linked: Issue 789719, that’s why.
  - sm4rk0 6y ago
    I don't get it... The latest issue I see there is #289797. Even if #789719 was a typo, I'm logged in but still getting a 404 for #289719. Maybe that's a private issue visible to you? Or your point is the sheer number of issues?

joshxyz 6y ago

Im worried on how it will go well with colours of issue labels. Exciting still <3

gfxgirl 6y ago

Dark mode has big issues with use generated content. you make a logo, diagram, or screenshot for your README, you can't make it dark/light compatible.

chrismorgan 6y ago
So long as the <picture> and <source> tags and the media attribute are whitelisted, you can do this: <picture> <source src=screenshot-dark.png media="(prefers-color-scheme: dark)"> <img src=screenshot-light.png> </picture> And then if the site is doing dark mode toggling by some means other than `@media (prefers-color-scheme: dark)`, it can go through and rewrite the media queries in all user-generated content, e.g. to change that one to media="all" in dark mode or media="not all" in light mode.
- deleted 6y ago
  [deleted]

SeeDave 6y ago

Perhaps I'm missing something here, or may be an arrogant internet neckbeard, but I'm always confused as to why people are often so eager/excited by dark mode (e.g. Slack around a year ago, or GitHub today) Isn't the implementation of 'Dark Mode' little more than a CSS Color palette and a toggle switch nested somewhere in user settings? Are people celebrating the usability over the technical feat? Seems like much ado about nothing :/

npteljes 6y ago
I completely agree, not to mention the questionable merits of dark mode in general. There are numerous third party solutions too, if someone really wanted them. I wish open standards were this popular.
- Can_Not 6y ago
  > questionable merits of dark mode in general I'm confused about what you find questionable about this, are you saying we shouldn't accommodate people with disabilities?
  - npteljes 6y ago
    Dark mode, besides looking cool, is sometimes promoted as healthier to the eyes, or using less energy to display the same content. These are the claims I think are questionable. The accessible color features will be cool.
    - spicybright 6y ago
      I like dark mode because it looks better, health claims or not.
gedy 6y ago
Yes it should be, but seems the reality is many sites and apps hardcode colors and don't have great separation of presentation from color. Many designers and product people have a hard time getting their head around views that might not look the same and to design for the content, not the picture, etc.

lumberingjack 6y ago

Hacker news used to be less waste of my time than it is now all of a sudden the liberals pile in and we got weird ass stupid stories that don't even matter voted to the top